Skip to content

Entities HAL-01 #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gRoussac wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

Entities HAL-01 #176

gRoussac wants to merge 11 commits into from

Conversation

@gRoussac
Copy link
Contributor

@gRoussac gRoussac commented Aug 18, 2025 •
edited
Loading

Updated get_immediate_caller and Add key_as_account_or_package Key conversion

maintains CEP-18 compatibility, and standardizes caller Key for balances and allowances dictionaries.

  • Updated get_immediate_caller to clearly map different caller kinds (ACCOUNT, CONTRACT, ENTITY) to a Key, handling:

    Legacy accounts + New entities account → AccountHash

    Legacy contract packages → ContractPackageHash

    New entities (not account)→ PackageHash

  • Introduced key_as_account_or_package helper to convert new-style Key returned by get_immediate_caller into a compatible Key (AccountHash / Hash), ensuring backward compatibility. Storage keeps Key (AccountHash / Hash).

  • Documented behavior

  • Testing note: In tests enabling Addressable entities in test builder is depending on added feature test-enable-addressable-entity . Test are now run with or without addressable-entity

@gRoussac
Copy link
Contributor Author

gRoussac commented Aug 18, 2025 •
edited
Loading

Will pass CI/CD on next release of casper node execution_engine_testing with uitls::create_run_genesis_request_with_chainspec_config

@gRoussac
Copy link
Contributor Author

gRoussac commented Jan 1, 2026

@darthsiroftardis Please bump execution_engine_testing https://github.com/casper-network/casper-node/blob/dev/execution_engine_testing/test_support/Cargo.toml#L3 to 8.1.2so that we can have this method uitls::create_run_genesis_request_with_chainspec_config

thanks!

@gRoussac gRoussac marked this pull request as ready for review January 1, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darthsiroftardis darthsiroftardis darthsiroftardis approved these changes

@devendran-m devendran-m Awaiting requested review from devendran-m

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gRoussac @darthsiroftardis